Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI for OSX #15

Closed
wants to merge 2 commits into from
Closed

Add UI for OSX #15

wants to merge 2 commits into from

Conversation

sqrt0b1000
Copy link

UI for OSX

Add a menu bar for OSX to control devices:

  • Add files from the OSX version and its dependency to WledLib
  • Split directory wled-native-iOS:
    • Shared files: wled-native
    • Exclusive iOS files: wled-native-iOS
    • Exclusive OSX files: wled-native-osx
  • Resolve setup issues from move of files
  • Extent README.md with the OSX content

Issue

Robert Brune added 2 commits December 1, 2023 05:09
# Shared files: wled#native
f106068 
    # Exclusive iOS files: `wled#native#iOS`
    # Exclusuve OSX files: `wled#native#osx`
Add OSX version and restructre project
a00895b 
- Add files from the OSX version and its depencency to WledLib
- Split directory `wled-native-iOS`:
    - Shared files:        `wled-native`
    - Exclusive iOS files: `wled-native-iOS`
    - Exclusuve OSX files: `wled-native-osx`
- Resolve setup issues from move of files
- Extend `README.md` with the OSX content
@sqrt0b1000 sqrt0b1000 mentioned this pull request Dec 8, 2023
Open
@Moustachauve
Copy link
Owner

Thank you for your contribution!

I feel like there should be at least some code in the shared folder, like discovering of devices, device API stuff, etc.
Is there a reason you kept both separate?

@sqrt0b1000
Copy link
Author

At this state I designed some details differently in the macOS app, e.g. no persistence through Core Data, other views and I changed the discovery service, so there is no shared data yet. Also, the preset selection is a macOS only feature at the moment.

I am working on using my WledLib also for the Device class of the iOS app, and then I think there is code that can be shared, as well as the views that can be used on both platforms.

@Moustachauve
Copy link
Owner

This now has conflicts.
Also, I feel like the code is not integrated well enough. It feels like two projects were added in the same repo instead of a single project that has support for many platforms.

@sqrt0b1000 sqrt0b1000 mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sqrt0b1000 @Moustachauve